CompatHelper with ITensorRegistry #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lkdvos I'm sure there are things that can be improved here, but I just tried to keep it as simple as possible for now for testing. I'm going to merge so I can test it out in NamedDimsArrays.jl (as you've mentioned before I think that is the only way to test these...). |
|
Ok, I think this worked (it is being used in NamedDimsArrays.jl here: https://github.com/ITensor/NamedDimsArrays.jl/blob/ca769ad41fc9021d39f88cc1b699d94b1235d473/.github/workflows/CompatHelper.yml, and I triggered it to run here: https://github.com/ITensor/NamedDimsArrays.jl/actions/runs/13209714746), though @lkdvos please take a look and let me know if there are improvements to make. |
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/JuliaRegistries/CompatHelper.jl/blob/v3.12.0/.github/workflows/CompatHelper.yml.
As @lkdvos mentioned in ITensor/ITensorPkgSkeleton.jl#47, ideally we would do something like https://github.com/julia-actions/julia-buildpkg/blob/v1.7.0/action.yml#L56-L63 to allow customizing which local registries to add, but for now I'm hard coding it to add the ITensorRegistry.